Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-6086] Updated permit condition extraction to happen asynchronously using Celery #3205

Merged
merged 5 commits into from
Aug 7, 2024
Merged

[MDS-6086] Updated permit condition extraction to happen asynchronously using Celery #3205

merged 5 commits into from
Aug 7, 2024

Conversation

simensma-fresh
Copy link
Collaborator

@simensma-fresh simensma-fresh commented Aug 6, 2024 •
edited
Loading

Objective

MDS-6086

  • Added a celery worker for local development that handles permit condition extraction jobs
  • Updated permit condition extraction endpoint to create a celery job
  • Added endpoints to retrieve the status and results of a permit condition job
  • A couple of tweaks to the test reporting scripts to fix a couple of issues that popped up when running it against large permits

image

henryoforeh-dev
henryoforeh-dev previously approved these changes Aug 6, 2024
View reviewed changes
@simensma-fresh simensma-fresh added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. labels Aug 6, 2024
henryoforeh-dev
henryoforeh-dev previously approved these changes Aug 7, 2024
View reviewed changes
@simensma-fresh
Copy link
Collaborator Author

@taraepp I updated the response models (the 202 now shows up in the swagger docs as well) + added an enum. Also added some missing tests.

image

@simensma-fresh simensma-fresh merged commit f61dac1 into develop Aug 7, 2024
6 checks passed
@simensma-fresh simensma-fresh deleted the MDS-6086_Permit-condition-extraction branch August 7, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinn134 asinn134 asinn134 approved these changes

@taraepp taraepp taraepp approved these changes

@matbusby-fw matbusby-fw Awaiting requested review from matbusby-fw

@henryoforeh-dev henryoforeh-dev Awaiting requested review from henryoforeh-dev

Assignees
No one assigned
Labels
💾 Backend This pull request includes backend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simensma-fresh @henryoforeh-dev @taraepp @asinn134